This repository has been archived by the owner on Jul 9, 2022. It is now read-only.
Bug fixes. closes #775 #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schmavery
approved these changes
Jan 23, 2020
|
Thanks for doing this, looks good. The other stuff sounds ok if we can do it cleanly enough |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some errors with mqtt. I also made the mqtt connecting a little better.
I would like to ask If I should do #771 too.
Another thing is that I want to refactor some stuff to support new events better and I want to do something like #628 to make everything clear and better.
Thanks!