Implement realpath instead of binding to C library
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulrikstrid
reviewed
May 22, 2019
| let fullPath = Filename.dirname(installationPath); | ||
| Some( | ||
| Lwt.return_some( | ||
| Local.{fullPath, name: Core.Filename.basename(fullPath), aliases: []}, |
There was a problem hiding this comment.
Still using Core.Filename here which is a problem on Windows
There was a problem hiding this comment.
Oh, I can take the changes you've made with @jordwalke's (and @reason-native's) Path.re and apply them here too 😄 But I don't want to make conflicts for #101
There was a problem hiding this comment.
Either you could just incorporate what I did in #101 and close my PR or we can chat on Discord to figure this out 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For future cross platform support
cc @ulrikstrid