Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XDG convention in MacOS too #1143

Merged
merged 5 commits into from
May 29, 2024
Merged

Support XDG convention in MacOS too #1143

merged 5 commits into from
May 29, 2024

Conversation

Schniz
Copy link
Owner

@Schniz Schniz commented May 29, 2024

This PR resolves #959 as it is based on it and I'm pushing more code to make it compatible with the changes done while it wasn't merged.

Thank you @utkarshgupta137 for the initial work 🙏

@Schniz Schniz self-assigned this May 29, 2024
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 2:55pm

Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 759b0fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@utkarshgupta137
Copy link
Contributor

Looks good to me, although I'm no longer using Node.js or fnm, so I won't be able to test this.

@Schniz Schniz marked this pull request as ready for review May 29, 2024 14:58
@kodiakhq kodiakhq bot merged commit f76a001 into master May 29, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the allow-xdg-in-macos branch May 29, 2024 16:04
@github-actions github-actions bot mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants