Make env smoke test pass when run with fish
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schniz
reviewed
Oct 8, 2019
package.json
Outdated
| @@ -73,7 +73,7 @@ | |||
| "update-fnm-package": "node ./.ci/prepare-fnm-package.js", | |||
| "verify-fnm-package": "node ./.ci/prepare-fnm-package.js --fail-on-difference", | |||
| "bootstrap": ".ci/bootstrap", | |||
| "test": "esy x TestFnm.exe", | |||
| "test": "bash -c '(esy x TestFnm.exe)'", | |||
There was a problem hiding this comment.
What do you think about changing the test to use --shell=bash explicitly instead of implying it here?
There was a problem hiding this comment.
😂
That's what I did first, but I thought you would want to keep testing System.Shell.infer(). Is that tested elsewhere?
There was a problem hiding this comment.
I suppose it is tested in the feature tests since they don't include --shell=bash explicitly. Would you prefer --shell=bash?
There was a problem hiding this comment.
I think that yes. This is a smoke test, not a full-blown test. I'd rather unit-test it with a feature test, where lots of things are implicit
Add `--shell=bash` so test passes when run with fish.
thomsj
force-pushed
the
run-test-with-bash
branch
from
64ccf85
to
7742c90
Compare
thomsj
changed the title
test script runs bashenv smoke test pass when run with fish
|
Looks great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure esy
testscript runsTestFnm.exeas child of bash process, asenvsmoke test fails when parent process is fish.