Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct PATH for npm install test #768

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

ixti
Copy link
Contributor

@ixti ixti commented Jul 4, 2022

Resolves: #755

@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2022

🦋 Changeset detected

Latest commit: 26ba33e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Schniz
Copy link
Owner

Schniz commented Jul 5, 2022

@ixti thanks for this! can you run cargo fmt to make sure it's formatted correctly? I can also do that if you prefer

@ixti
Copy link
Contributor Author

ixti commented Jul 5, 2022

@Schniz fixed. Forgot to run it beforehand. :D

@ixti ixti force-pushed the improve-npm-download-test branch from 39a3bcf to 36c5df2 Compare July 5, 2022 15:23
@ixti
Copy link
Contributor Author

ixti commented Jul 20, 2022

@Schniz Hi, is there anything I can do to make this PR being merged? Would like to have smaller patch-set for my Gentoo ebuilds ;D

@Schniz Schniz added the PR: Bugfix A bug was fixed label Jul 20, 2022
@Schniz Schniz merged commit d62e17d into Schniz:master Jul 20, 2022
@Schniz
Copy link
Owner

Schniz commented Jul 20, 2022

Sorry about the delay!

@ixti
Copy link
Contributor Author

ixti commented Jul 21, 2022

@Schniz Thank you!

@ixti ixti deleted the improve-npm-download-test branch July 21, 2022 02:15
@github-actions github-actions bot mentioned this pull request Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bugfix A bug was fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm installation test uses wrong node version
2 participants