Add support for log level (closes #33) #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schniz
reviewed
Apr 16, 2019
| @@ -0,0 +1,19 @@ | |||
| type t = | |||
There was a problem hiding this comment.
Consider moving this file to the Logger module
There was a problem hiding this comment.
That's where it was initially, but I had a cyclic dependency Config -> Logger -> Config because Config needs the log level and Logger needs the config value in runtime
|
I added the flag to the readme, I didn't elaborate as I think it's self explanatory, but let me know otherwise. |
|
Sorry I haven’t looked at it yet. I’m on vacation 🇵🇱 |
Schniz
reviewed
Apr 28, 2019
Schniz
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports "quiet", "error" and "all".