feat(25): make models optionals #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you have no patience 😆 |
|
@Wabri I'm sorry broski ma già a lavoro ho I bottle neck di ownership che mi fan girare inutilmente le balls e sclerando ho mergiato. Could you please add the protection on the branch? |
|
No problem brothersky, I saw the code and I didn't find any major problem. Thanks to have time to develop it 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
This PR will make the .pt files optionals and loadable from this repository.
On the latest release the package was having a 30MB size standalone and more than 700 MB if we consider the dependencies.
We should let the user decide which algorithm use for converting an image.
After this PR, we're going to release a minor.