-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(43): Add e2e tests with playwright #75
Open
TheJoin95
wants to merge
9
commits into
main
Choose a base branch
from
feat/43-playwright
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJoin95
force-pushed
the
feat/43-playwright
branch
5 times, most recently
from
October 29, 2024 23:41
1e0b04e
to
e99c6af
Compare
TheJoin95
force-pushed
the
feat/43-playwright
branch
3 times, most recently
from
October 30, 2024 09:14
1374a94
to
bb6e8e0
Compare
TheJoin95
force-pushed
the
feat/43-playwright
branch
from
October 30, 2024 09:17
bb6e8e0
to
fc66b64
Compare
Should this be rebased on top of the previous one? |
@404answernotfound yes, I'll rebase after the other PR is going to be merged. I needed this to verify and avoid the mix of vitest with playwright context |
TheJoin95
force-pushed
the
feat/43-playwright
branch
from
October 30, 2024 11:28
a11f2e8
to
2fb0a8e
Compare
@404answernotfound now the two pipelines are green, please review again, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Add E2E test via playwright
β Type of change
π Description
π Checklist