Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(OnyxSelectInput): support validation #1408

Merged
merged 32 commits into from
Jun 26, 2024
Merged

feat(OnyxSelectInput): support validation #1408

merged 32 commits into from
Jun 26, 2024

Conversation

BoppLi
Copy link
Contributor

@BoppLi BoppLi commented Jun 25, 2024 •
edited
Loading

Relates to #1302

  • feat(createComboBox): open flyout on text input for searchable combo boxes. Fix close/open bug when selecting with space
  • feat(OnyxSelectInput): support validity handling
    • internal input is not readonly, but blocks all character inputs
    • supports translated error message for empty required inputs
    • align styles
  • feat(global.css): include layers order to prevent hierarchy issues

Checklist

  • The added / edited code has been documented with JSDoc
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

BoppLi and others added 21 commits June 20, 2024 17:41
@BoppLi
implement validity for onyxselect
4104049
@BoppLi
rename selection to modelValue so validityChange events fire
4d2062e
@BoppLi
refactor OnyxSelectInput API
ddb6384
@BoppLi
Merge remote-tracking branch 'origin/main' into feat/1302-support-val…
da1729d 
…idation-for-select
@BoppLi
include select in form demo + improve layout
a660014
@BoppLi
docs(changeset): feat(global.css): include layers order to prevent hi…
584664b 
…erarchy issues
@BoppLi
fix visibility error for error tooltip
d939b59
@BoppLi
fix select input story/test
b31a9ad
@BoppLi
use onyxSelect for language selection
1331cd8
@BoppLi
implement composable to synchronize selectOptions
53c9e66
@BoppLi
update composable
e2703c6
@BoppLi
remove redundant composable
56f158d
@BoppLi
cleanup
3fa7ad0
@BoppLi
Merge remote-tracking branch 'origin/main' into feat/1302-support-val…
01f75d2 
…idation-for-select
@BoppLi
cleanup readonly logic for OnyxSelectInput. instead, prevent typing.
ca90103
@BoppLi
fix styles
c0b0b69
@BoppLi
fix focus during select search
24d6803
@BoppLi
fix border color for readonly
d0f0c61
@BoppLi
rename screenshot label
33330ee
@BoppLi
allow all navigational keys for OnyxSelectInput
948ca0a
@github-actions @BoppLi
chore: update Playwright screenshots (#1407)
bd3f841 
This is an auto-generated pull request. All Playwright screenshots have
been updated.

Co-authored-by: BoppLi <151019977+BoppLi@users.noreply.github.com>
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b00586c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@sit-onyx/headless Minor
sit-onyx Minor
alpha-test-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/storybook-utils Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions @BoppLi
chore: update Playwright screenshots (#1416)
4aeeac1 
This is an auto-generated pull request. All Playwright screenshots have
been updated.

Co-authored-by: BoppLi <151019977+BoppLi@users.noreply.github.com>
@BoppLi BoppLi marked this pull request as ready for review June 26, 2024 10:12
@BoppLi BoppLi requested a review from a team as a code owner June 26, 2024 10:12
@BoppLi BoppLi enabled auto-merge (squash) June 26, 2024 10:12
@JoCa96 JoCa96 self-assigned this Jun 26, 2024
@BoppLi BoppLi requested a review from JoCa96 June 26, 2024 13:57
@BoppLi BoppLi merged commit 0bdb49a into main Jun 26, 2024
19 checks passed
@BoppLi BoppLi deleted the feat/1302-support-validation-for-select branch June 26, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoCa96 JoCa96 JoCa96 approved these changes

Assignees

@JoCa96 JoCa96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoppLi @JoCa96