Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve docs page performance by only showing default example #1898

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

JoCa96
Copy link
Collaborator

@JoCa96 JoCa96 commented Sep 25, 2024

There is a noticeable lag on when typing into the input of the OnyxInput.

Cause

I am concluding that the issue lie with Storybook:

  • I performed a cursory performance check using the Vue Dev Tools and there are no apparent performance issues with our Vue components.
  • The Storybook input elements are also affected

Mitigation

I removed all, but the Default Story example from the docs page.
This should mitigate bigger lagging issues for now.

@JoCa96 JoCa96 requested a review from a team as a code owner September 25, 2024 13:22
Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: e7e8ace

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoCa96 JoCa96 enabled auto-merge (squash) September 26, 2024 08:09
@JoCa96 JoCa96 merged commit 21e5f99 into main Sep 26, 2024
19 checks passed
@JoCa96 JoCa96 deleted the joca96/chore-improve-storybook-performance branch September 26, 2024 08:23
@larsrickert
Copy link
Collaborator

@JoCa96 The issue with this "solution" is that the code snippets for most examples can now not be seen/copied which lowers their value quiet a lot :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants