Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OnyxTab): support disabled and skeleton property #2069

Merged
merged 13 commits into from
Nov 13, 2024

Conversation

larsrickert
Copy link
Collaborator

Relates to #2018

Please merge #2061 first so I can check/adjust the keyboard behaviour to skip disabled/skeleton tabs

Checklist

  • The added / edited code has been documented with JSDoc
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 023fadf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
sit-onyx Minor
@sit-onyx/headless Minor
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@larsrickert larsrickert force-pushed the feat/2018-tabs-disabled branch 3 times, most recently from c44b058 to 0118884 Compare November 12, 2024 11:23
@larsrickert larsrickert marked this pull request as ready for review November 12, 2024 12:42
@larsrickert larsrickert requested a review from a team as a code owner November 12, 2024 12:42
@JoCa96 JoCa96 self-assigned this Nov 13, 2024
Copy link
Collaborator

@JoCa96 JoCa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are optional

packages/sit-onyx/src/composables/useSkeletonState.ts Outdated Show resolved Hide resolved
packages/sit-onyx/src/components/OnyxTab/types.ts Outdated Show resolved Hide resolved
@larsrickert larsrickert merged commit a3eb7d0 into main Nov 13, 2024
17 checks passed
@larsrickert larsrickert deleted the feat/2018-tabs-disabled branch November 13, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants