Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OnyxDataGrid): Render icons in flyout #2322

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MajaZarkova
Copy link
Contributor

Relates to #1939

When listItems are not set the icons will be rendered inside the flyout

Checklist

  • The added / edited code has been documented with JSDoc

@MajaZarkova MajaZarkova requested a review from a team as a code owner December 12, 2024 12:22
Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 83525e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@JoCa96 JoCa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the iconComponents (or rather the OnyxSystemButtons) inside the list creates a whole suite of issues:

  • the hover effect behaves incorrectly
  • there is no visual text label
  • from UX side: I pretty sure OnyxSystemButton is not allowed to be used in the list

Screenshot 2024-12-12 at 15 22 51

Either we

  • add a new support component which renders to a OnyxSystemButton or listitem based on the context
  • or we just make listItems a required property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants