Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix css ordering in storybook #2330

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoCa96
Copy link
Collaborator

@JoCa96 JoCa96 commented Dec 13, 2024

Closes #2311

Vite doesn't consider the order of CSS includes/imports (See vitejs/vite#3924).
This causes issues for us in production, where we rely on the layer definitions to be defined first.

As a fix, we disable CSS code splitting: There isn't really a downside to this, it's a single, slightly bigger CSS file instead of many smaller ones.

@JoCa96 JoCa96 requested a review from a team as a code owner December 13, 2024 08:04
Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: b76cc31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoCa96 JoCa96 enabled auto-merge (squash) December 13, 2024 08:12
@JoCa96 JoCa96 force-pushed the joca96/2311-fix-css-order-incorrect-in-storybook branch from 979cc45 to eed672f Compare December 13, 2024 08:58
Copy link
Collaborator

@larsrickert larsrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix the issue for me...if you run "pnpm build:storybook && pnpm preview", the CSS layers are still broken

@larsrickert larsrickert self-assigned this Dec 13, 2024
@JoCa96 JoCa96 force-pushed the joca96/2311-fix-css-order-incorrect-in-storybook branch from eed672f to b76cc31 Compare December 13, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix and investigate layers not working correctly in Storybook
2 participants