Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scion-rcp): make headless flag API #83

Merged
merged 1 commit into from
Jul 16, 2024
Merged

feat(scion-rcp): make headless flag API #83

merged 1 commit into from
Jul 16, 2024

Conversation

ruadrian
Copy link
Contributor

No description provided.

@ruadrian ruadrian requested a review from ozohje July 15, 2024 21:28
@ruadrian ruadrian requested a review from iachelini July 16, 2024 06:13
@ruadrian ruadrian requested review from ozohje and removed request for ozohje July 16, 2024 06:14
iachelini
iachelini approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@iachelini iachelini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have loved to keep a default method with previous inital state of "false", but since we are the only consumers its absolutely fine for now.

@iachelini iachelini merged commit 8349684 into master Jul 16, 2024
4 checks passed
@iachelini iachelini deleted the feature/allow-headless-host-context branch July 16, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iachelini iachelini iachelini approved these changes

@ozohje ozohje Awaiting requested review from ozohje

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruadrian @iachelini