Separate out transforms from OperatorKernels #46
Conversation
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 91.78% 93.33% +1.55%
==========================================
Files 5 6 +1
Lines 73 90 +17
==========================================
+ Hits 67 84 +17
Misses 6 6
Continue to review full report at Codecov.
|
Extend `OperatorKernel` to `OperatorKernel{<:AbstractTransform}`
Change `fourier.jl` to `operator_kernel.jl`
| """ | ||
| AbstractTransform | ||
|
|
||
| ## Interface |
There was a problem hiding this comment.
Should be in documentation.
There was a problem hiding this comment.
The doc string will add into the doc automatically I think. Maybe an extra paragraph is needed to discribe how things work? We'll see
There was a problem hiding this comment.
Yeah, that's what I mean. Introduction to interfaces should have extra paragraph in doc and should not be in docstring. That way docstring will be too much while the interfaces are many.
src/fourier.jl
Outdated
| SpectralConv( | ||
| ch, modes; | ||
| OperatorConv( | ||
| ch, modes, transform; |
There was a problem hiding this comment.
I think transform should move before ch or modes.
close #40
TODO:
FourierOperatortoOperatorKernelAbstractTransformOperatorKernelbased onAbstractTransformOperatorKerneltoOperatorKernel{<:AbstractTransform}SpectralConvfunction as a constructor ofOperatorKernel{FourierTransform}