Skip to content
This repository has been archived by the owner on Sep 28, 2024. It is now read-only.

Fix GraphKernel #75

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Fix GraphKernel #75

merged 1 commit into from
Jul 7, 2022

Conversation

yuehhua
Copy link
Collaborator

@yuehhua yuehhua commented Jun 29, 2022

Closes #74

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #75 (6cbc9e8) into master (d6dbe6b) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 6cbc9e8 differs from pull request most recent head cf34d62. Consider uploading reports for the commit cf34d62 to get more accurate results

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   94.48%   94.65%   +0.16%     
==========================================
  Files           9        8       -1     
  Lines         127      131       +4     
==========================================
+ Hits          120      124       +4     
  Misses          7        7              
Impacted Files Coverage Δ
src/operator_kernel.jl 100.00% <100.00%> (ø)
src/Transform/fourier_transform.jl 100.00% <0.00%> (ø)
src/NOMAD/NOMAD.jl
src/FNO/FNO.jl
src/DeepONet/subnets.jl
src/graph_kernel.jl
src/DeepONet/DeepONet.jl
src/model.jl 100.00% <0.00%> (ø)
src/subnets.jl 100.00% <0.00%> (ø)
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yuehhua
Copy link
Collaborator Author

yuehhua commented Jul 1, 2022

It needs support of positional encoding as edge feature to feed into the model. It may need some design from GeometricFlux.

@yuehhua yuehhua force-pushed the gno branch 2 times, most recently from 6cbc9e8 to eafcd7f Compare July 7, 2022 08:41
@yuehhua yuehhua marked this pull request as ready for review July 7, 2022 13:26
@yuehhua
Copy link
Collaborator Author

yuehhua commented Jul 7, 2022

Maybe fix GraphKernel layer first. I will fix the example later.

@yuehhua yuehhua requested a review from foldfelis July 7, 2022 13:27
@yuehhua yuehhua changed the base branch from master to main July 7, 2022 13:46
Copy link
Contributor

@foldfelis foldfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow~~

@foldfelis foldfelis merged commit f1d680a into SciML:main Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graph neural operator
2 participants