Skip to content
This repository has been archived by the owner on Sep 28, 2024. It is now read-only.

Automatically chose eltype of OperatorConv weights #84

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

tknopp
Copy link
Contributor

@tknopp tknopp commented Aug 20, 2022

I tried to replace FourierTransform with ChebychevTransform in OperatorKernel but this did not work since the later implicitly assumes complex weights in the OperatorConv. I changed it such that the eltype is derived from the Transform.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #84 (1a5b271) into main (60b7726) will decrease coverage by 0.84%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   90.17%   89.32%   -0.85%     
==========================================
  Files          10       10              
  Lines         173      178       +5     
==========================================
+ Hits          156      159       +3     
- Misses         17       19       +2     
Impacted Files Coverage Δ
src/Transform/chebyshev_transform.jl 94.11% <0.00%> (-5.89%) ⬇️
src/operator_kernel.jl 98.27% <66.66%> (-1.73%) ⬇️
src/Transform/fourier_transform.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yuehhua yuehhua changed the title Automatically chose eltype of OperatorConv weigths Automatically chose eltype of OperatorConv weights Aug 29, 2022
@yuehhua
Copy link
Collaborator

yuehhua commented Aug 29, 2022

It looks good to me.

@yuehhua yuehhua merged commit 0e58876 into SciML:main Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants