Skip to content
This repository has been archived by the owner on Sep 28, 2024. It is now read-only.

Change FFT to Real to Complex FFT #87

Merged
merged 5 commits into from
Nov 29, 2022
Merged

Change FFT to Real to Complex FFT #87

merged 5 commits into from
Nov 29, 2022

Conversation

tknopp
Copy link
Contributor

@tknopp tknopp commented Aug 27, 2022

Closes #85. This corresponds to the orginal FNO architecture and as outlined in #85, using the ordinary FFT will create different results. I would even say wrong results although the network might be able to correct this.

@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #87 (fed68b8) into main (60b7726) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   90.17%   90.44%   +0.27%     
==========================================
  Files          10       10              
  Lines         173      178       +5     
==========================================
+ Hits          156      161       +5     
  Misses         17       17              
Impacted Files Coverage Δ
src/Transform/chebyshev_transform.jl 100.00% <100.00%> (ø)
src/Transform/fourier_transform.jl 100.00% <100.00%> (ø)
src/operator_kernel.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tknopp
Copy link
Contributor Author

tknopp commented Nov 18, 2022

@yuehhua @ChrisRackauckas: What's your take on this?

@tknopp
Copy link
Contributor Author

tknopp commented Nov 27, 2022

@foldfelis could you have a look? I am not sure who is maintaining this package. I developed a package based on NeuralOperators.jl and require the rfft patch.

@yuehhua
Copy link
Collaborator

yuehhua commented Nov 28, 2022

Could you retain the coding style as usual?

@tknopp
Copy link
Contributor Author

tknopp commented Nov 28, 2022

Could you retain the coding style as usual?

Sure, but could you give me a hint where this is not done? I tried to see it but it seems the coding style matches.

@yuehhua
Copy link
Collaborator

yuehhua commented Nov 29, 2022

A simple way to format the coding style:
Change your directory to the NeuralOperators.jl folder and run the following code:

using JuliaFormatter
format(".", verbose=true)

It will format all the code in current folder for you.

@yuehhua
Copy link
Collaborator

yuehhua commented Nov 29, 2022

It looks good to me.

@yuehhua yuehhua merged commit 3a2d04f into SciML:main Nov 29, 2022
@tknopp
Copy link
Contributor Author

tknopp commented Nov 29, 2022

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Real to Complex FFT
2 participants