Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NNKolmogorov and NNParamKolmogorov #83

Merged
merged 22 commits into from
Feb 15, 2024

Conversation

ashutosh-b-b
Copy link
Contributor

@ashutosh-b-b ashutosh-b-b commented Jan 30, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (62b0d93) 61.97% compared to head (8fb87fe) 68.20%.

❗ Current head 8fb87fe differs from pull request most recent head aaa400d. Consider uploading reports for the commit aaa400d to get more accurate results

Files Patch % Lines
src/NNKolmogorov.jl 97.72% 1 Missing ⚠️
src/NNParamKolmogorov.jl 98.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   61.97%   68.20%   +6.22%     
==========================================
  Files           8       10       +2     
  Lines         647      758     +111     
==========================================
+ Hits          401      517     +116     
+ Misses        246      241       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashutosh-b-b
Copy link
Contributor Author

Needs #81 to go in first.

@ashutosh-b-b ashutosh-b-b force-pushed the bb/nn_kolmogorov branch 2 times, most recently from 2799c06 to 9f19381 Compare February 12, 2024 17:12
@ashutosh-b-b ashutosh-b-b marked this pull request as ready for review February 12, 2024 17:48
```math
\partial_t u(t,x) = \mu(t, x, γ_mu) \nabla_x u(t,x) + \frac{1}{2} \sigma^2(t, x, γ_sigma) \Delta_x u(t,x)
```
with initial condition given by `g(x, γ_phi)`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

terminal condition? I'm not sure this really matches??

Copy link
Contributor Author

@ashutosh-b-b ashutosh-b-b Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

From : https://arxiv.org/pdf/1806.00421.pdf
Incase of forward eqns it is the initial condition.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes in forward equations it's an initial condition. But for backwards we have a terminal condition. How are the two separate cases being handled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't in this case the conversion as simple as v(t,x) = u(T - t, x) for changing from fwd to backward. I found this:
image

I got this from here : https://jberner.info/data/Thesis_Berner.pdf

```math
\partial_t u(t,x) = \mu(t, x) \nabla_x u(t,x) + \frac{1}{2} \sigma^2(t, x) \Delta_x u(t,x)
```
with initial condition given by `g(x)`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terminal condition?

@ChrisRackauckas ChrisRackauckas merged commit a5acc69 into SciML:main Feb 15, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants