Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and clear documentation #96

Merged
merged 11 commits into from
Jul 7, 2024
Merged

Conversation

ashutosh-b-b
Copy link
Contributor

No description provided.

@@ -2,6 +2,8 @@
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
Flux = "587475ba-b771-5e3f-ad9e-33799f191a9c"
HighDimPDE = "57c578d5-59d4-4db8-a490-a9fc372d19d2"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing cuda and nnlibcuda

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added CUDA: cad2d35.
We donot need NNlibCUDA

@ChrisRackauckas ChrisRackauckas merged commit 19fb9c7 into SciML:main Jul 7, 2024
10 checks passed
@@ -119,7 +119,7 @@ sol = solve(prob,

[`DeepSplitting`](@ref deepsplitting) can run on the GPU for (much) improved performance. To do so, just set `use_cuda = true`.

```@example DeepSplitting_non_local_PDE
```julia
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with this? The doc build on Buildkite has GPUs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the GHA action doesnot, it errors since DeepSplitting throws an error when use_cuda is true and CUDA isn't functional

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GHA should be removed since hte docs build via buildkite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants