Documenter 1.0 upgrade #352
Conversation
|
Is this package going to keep using an older formatting style? Or has it just not been updated. |
|
update it later |
|
Why did this get merged? SciMLStyle is still not fixed to my knowledge, and this now breaks the formatting here even worse by formatting with the broken style version? Please revert this and open a clean PR with just the doc updates. |
|
A mass restyle also shouldn’t be included as part of anything but a separate PR. |
| end | ||
|
|
||
| ############################################## | ||
|
|
||
| function get_num_majumps(smaj::SpatialMassActionJump{Nothing, Nothing, S, U, V}) where | ||
| function get_num_majumps(smaj::SpatialMassActionJump{ |
There was a problem hiding this comment.
@ChrisRackauckas this kind of reformatting is exactly what we discussed in that thread, which breaks VSCode functionality, and has readability issues. It is why we haven't reformatted while awaiting the fix to that thread, since it seems like this is a non-reversible format change (i.e. the formatter itself won't fix this in the future).
|
Sorry I thought this was just another one of the Documenter v1.0 upgrades. I didn't note the formatter changes slipped in. |
|
Can we revert this then and just put through the doc changes as a small PR without format changes? |
|
yes |
No description provided.