Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc cleanup prototype #240

Merged
merged 1 commit into from
Dec 11, 2022
Merged

doc cleanup prototype #240

merged 1 commit into from
Dec 11, 2022

Conversation

ArnoStrouwen
Copy link
Member

  • preview cleanup CI taken from MuladdMacro.jl
  • enable preview
  • remove analytics

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #240 (2a32885) into main (b91b2bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   64.86%   64.86%           
=======================================
  Files          12       12           
  Lines         703      703           
=======================================
  Hits          456      456           
  Misses        247      247           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas
Copy link
Member

Where would one see the preview?

@fredrikekre
Copy link
Contributor

Documenter will post a commit status with the link. It only works on PRs from branches in the same repository, because otherwise the SSH key is not available (so it won't post any preview for this PR). Here is an example: fredrikekre/Literate.jl#195 (open the commit status, click the link under documenter/deploy > Details).

@ChrisRackauckas
Copy link
Member

I don't see that same preview link here?

@ArnoStrouwen
Copy link
Member Author

As @fredrikekre said, no preview links from forks.

@ChrisRackauckas ChrisRackauckas merged commit a0facd9 into SciML:main Dec 11, 2022
@ArnoStrouwen ArnoStrouwen deleted the cleanup branch May 13, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants