Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unnecessary allocations and reuse code #297

Merged
merged 25 commits into from
Dec 7, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Nov 29, 2023

Fixes #291

Checklist

Additional context

Add any other context about the problem here.

@avik-pal avik-pal marked this pull request as ready for review December 5, 2023 17:36
@avik-pal
Copy link
Member Author

avik-pal commented Dec 5, 2023

Tests should pass once the linked PRs are merged

@avik-pal avik-pal mentioned this pull request Dec 5, 2023
2 tasks
@avik-pal avik-pal mentioned this pull request Dec 5, 2023
3 tasks
@avik-pal avik-pal closed this Dec 7, 2023
@avik-pal avik-pal reopened this Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (657c549) 93.07% compared to head (3b52a5a) 87.40%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/utils.jl 82.90% 20 Missing ⚠️
src/levenberg.jl 91.48% 8 Missing ⚠️
src/trace.jl 58.82% 7 Missing ⚠️
src/gaussnewton.jl 81.81% 6 Missing ⚠️
src/jacobian.jl 92.95% 5 Missing ⚠️
src/lbroyden.jl 92.18% 5 Missing ⚠️
src/trustRegion.jl 95.79% 5 Missing ⚠️
src/NonlinearSolve.jl 89.47% 4 Missing ⚠️
src/pseudotransient.jl 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
- Coverage   93.07%   87.40%   -5.68%     
==========================================
  Files          21       21              
  Lines        2065     1683     -382     
==========================================
- Hits         1922     1471     -451     
- Misses        143      212      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 5b14b20 into SciML:master Dec 7, 2023
9 of 22 checks passed
@ChrisRackauckas
Copy link
Member

The docs build needs to be fixed though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagate linsolve_kwargs into the linear solver cache
2 participants