Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storing the trace #304

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Fix storing the trace #304

merged 3 commits into from
Dec 7, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Dec 7, 2023

No description provided.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5b14b20) 87.40% compared to head (4d605b9) 88.01%.

Files Patch % Lines
src/trace.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   87.40%   88.01%   +0.61%     
==========================================
  Files          21       21              
  Lines        1683     1669      -14     
==========================================
- Hits         1471     1469       -2     
+ Misses        212      200      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal
Copy link
Member Author

avik-pal commented Dec 7, 2023

The lintcheck will be fixed once SciML/SimpleNonlinearSolve.jl#107 is
in. But bumping SimpleNonlinearSolve compact requires a breaking change which is a part of #302

@avik-pal
Copy link
Member Author

avik-pal commented Dec 7, 2023

This is ready

@ChrisRackauckas ChrisRackauckas merged commit 021901e into SciML:master Dec 7, 2023
9 of 12 checks passed
@avik-pal avik-pal deleted the ap/fix_docs branch December 7, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants