refactor: migrate to LineSearch.jl #461
Draft
+85
−500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/linesearch
branch
from
aac8a99
to
865bc1b
Compare
|
Tests do pass locally. Now we need to just wait for SciMLJacobianOperators to merge, followed by LineSearch to get a tag. |
avik-pal
force-pushed
the
ap/linesearch
branch
2 times, most recently
from
5485267
to
40c4df9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
avik-pal
force-pushed
the
ap/linesearch
branch
4 times, most recently
from
5c864d2
to
4ee4593
Compare
avik-pal
force-pushed
the
ap/linesearch
branch
from
17c71e3
to
947fb85
Compare
avik-pal
force-pushed
the
ap/linesearch
branch
from
947fb85
to
b2d061a
Compare
avik-pal
force-pushed
the
ap/linesearch
branch
from
e565c19
to
276b72b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sooo many bad design decisions I had made are now returning to haunt me....
TODOs
reinit!