-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define prepare_alg dispatch for OrdinaryDiffEq AD algorithms #1470
Conversation
94ff654
to
8a0a2b5
Compare
8a4d1c3
to
2830d6f
Compare
This may be the primary cause of the inference regression in Pumas. |
This PR causes the biggest decrease to compile times 😅 |
Well, commenting out the function barrier |
But having this allows for the things to fully precompile, which is the full 22 to 3 seconds precompile 🌊 |
Yeah, I think a better fix is to just avoid the type instability in Pumas (by passing the chunk size in there), which requires #1521. |
Requires SciML/DiffEqBase.jl#698