Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepcopy prob.noise #496

Merged
merged 18 commits into from
Sep 17, 2022
Merged

deepcopy prob.noise #496

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c05d7e1
deepcopy prob.noise
rmsrosa Aug 18, 2022
1666719
Merge branch 'SciML:master' into noise_hygiene
rmsrosa Aug 23, 2022
24fe115
Merge branch 'master' into noise_hygiene
rmsrosa Aug 24, 2022
6cf5985
deepcopy integrator instead
rmsrosa Aug 24, 2022
9564e24
deepcopy integrator.sol.W to prob.noise
rmsrosa Aug 26, 2022
36988e3
Merge branch 'master' into noise_hygiene
rmsrosa Aug 28, 2022
2c3948d
deepcopy back to prob.noise
rmsrosa Aug 28, 2022
9923508
Merge branch 'master' into noise_hygiene
rmsrosa Sep 12, 2022
c55ab21
`alias_noise` keyword to solve.
rmsrosa Sep 13, 2022
6528aeb
properly handle noise according to `alias_noise`
rmsrosa Sep 14, 2022
0768f81
test `alias_noise` keyword
rmsrosa Sep 14, 2022
f7bba5a
Merge branch 'master' into noise_hygiene
rmsrosa Sep 15, 2022
a6d7e60
update compat for DiffEqBase
rmsrosa Sep 15, 2022
e28c49d
use `kwargs[alias_noise] === true`
rmsrosa Sep 15, 2022
d975fa5
another `=== true`
rmsrosa Sep 15, 2022
31e6042
little things
rmsrosa Sep 16, 2022
e38c7eb
garbage collect in reversal tests
rmsrosa Sep 17, 2022
1ef9baf
GC inside the inner loop
rmsrosa Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ function DiffEqBase.__solve(prob::DiffEqBase.AbstractRODEProblem,
kwargs...) where recompile_flag
integrator = DiffEqBase.__init(prob,alg,timeseries,ts,recompile;kwargs...)
solve!(integrator)
integrator.sol
deepcopy(integrator.sol)
rmsrosa marked this conversation as resolved.
Show resolved Hide resolved
end

# Make it easy to grab the RODEProblem/SDEProblem/DiscreteProblem from the keyword arguments
Expand Down Expand Up @@ -412,7 +412,7 @@ function DiffEqBase.__init(
=#
end
elseif typeof(prob) <: DiffEqBase.AbstractRODEProblem
W = deepcopy(prob.noise)
W = prob.noise
if W.reset
if W.curt != t
reinit!(W,t,t0=t)
Expand Down