Remove GeoAxes patch at next Cartopy release

[trexfeathers]

📰 Custom Issue

SciTools/cartopy#2390

iris/lib/iris/plot.py

Lines 46 to 60 in 57096f2

	class _GeoAxesPatched(cartopy.mpl.geoaxes.GeoAxes):
	# TODO: see cartopy#2390
	# Remove this once the bug is addressed in a Cartopy release.
	def _draw_preprocess(self, renderer):
	super()._draw_preprocess(renderer)
	for artist in self.artists:
	if hasattr(artist, "_draw_gridliner"):
	# Note this is only necessary since Cartopy v0.23, but is not
	# wasteful for earlier versions as _draw_gridliner() includes
	# a check for whether a draw is necessary.
	artist._draw_gridliner(renderer=renderer)
	cartopy.mpl.geoaxes.GeoAxes = _GeoAxesPatched

[rcomer]

Cartopy 0.24 is now out.

[schlunma]

Hi!

With the release of cartopy 0.24 the current iris 3.10.0 package on conda-forge will throw the following exception when trying to plot a map:

TypeError: _GeoAxesPatched._draw_preprocess() missing 1 required positional argument: 'renderer' 

I could trace back this error to the piece of code that you mention here (i.e., removing it solves this error).

MRE:

import matplotlib.pyplot as plt

import iris
import iris.quickplot as qplt

fname = iris.sample_data_path("air_temp.pp")
temperature_cube = iris.load_cube(fname)

# Draw the contour with 25 levels.
qplt.contourf(temperature_cube, 25)

# Add coastlines to the map created by contourf.
plt.gca().coastlines()

plt.show()

[rcomer]

Ah, that would be my fault again 😬 . renderer wasn't getting used in _draw_preprocess so we removed that at SciTools/cartopy#2424

[trexfeathers]

I'm working on it right now guys: #6171.

Unfortunately updating to Cartopy 0.24 has produced some material image test failures so I need to make sure I understand why before we can move forward.

If that takes too long or I'm too dumb then I'll have to use a pin in the short term.

[valeriupredoi]

cheers, guys! We're gonna pin ESMValTool's cartopy<0.24 right now, and will release a new build with it 👍

[trexfeathers]

@pp-mo I currently have no intention of removing the patch at the next Cartopy release. Could you explain the re-opening? You mentioned to me offline that in several years' time we will probably have a minimum pin >0.23, but that's a long way off and I wouldn't want to use an issue to track something like that.

[pp-mo]

@trexfeathers I currently have no intention of removing the patch at the next Cartopy release. Could you explain the re-opening? You mentioned to me offline that in several years' time we will probably have a minimum pin >0.23, but that's a long way off and I wouldn't want to use an issue to track something like that.

OK I get it, we don't have a way of scheduling this, so let's just leave it there