Support name tokens #3399
Merged
Support name tokens #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lbdreyer I still need to add some test coverage to the PR... just pushed this so that you can see the approach I'm taking 😉 |
bjlittle
commented
Sep 13, 2019
| @@ -19,15 +19,18 @@ | |||
| from six.moves import (filter, input, map, range, zip) # noqa | |||
| import six | |||
|
|
|||
| # TODO: Is this a mixin or a base class? | |||
|
|
|||
|
@lbdreyer Okay, I think that I'm pretty much there... As it happens, there wasn't any unit test coverage of Being a good citizen, I'll add test coverage in a separate PR. I've also not updated the docs either, just so that this PR can get banked sooner rather than later, but happy to make a follow-up PR, if you think that's appropriate... 😄 |
lbdreyer
requested changes
Sep 17, 2019
|
@lbdreyer I've actioned all your review comments, |
|
All good 👍 👍 Thanks @bjlittle ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the outcome of a side discussion regarding issue #3360.
In short, in
iriswe've allowed the use oflong_namefrom a coordinate to be used in the construction of theCellMethod, but that causes issues when thelong_namecontains one or more space (" ") characters, as it then quickly becomes ambiguous to parse the grammar suggested in the CF Conventions for acell_methodsattribute on loading after saving theCellMethodto NetCDF. That's not a fault of the CF Conventions, more our interpretation and implementation of it (from a file format agnostic point of view).Reference, Cell Methods, 2nd paragraph:
That said, this PR attempts to resolve this issue by ensuring that the
coord_namesandmethodused within the construction of aCellMethodare valid NetCDF name tokens, and thus can be parsed within the rules suggested in the CF Conventions without ambiguity (or over-engineering 😉).