drop black and flake8 dependencies #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjlittle
force-pushed
the
drop-black-and-flake8-conda-requriments
branch
from
bddadaf
to
5eb9868
Compare
trexfeathers
requested changes
Jun 7, 2021
There was a problem hiding this comment.
Thanks @bjlittle.
I like pre-commit being the 'single entry point'. But with that being the case there are a few extra changes I'd like to see:
- Could we change the Nox linting session to do a manual run of pre-commit?
- If we can't do that, what about my previous suggestion to have Nox read the black version from pre-commit?
- Either with the current permutation, or with any of my suggested changes, please could you include some minor documentation changes?
contributing_code_formatting.rstandcontributing_running_tests.rst.
|
@trexfeathers Cool. I'll get And I'll add something to the docs 👍 |
bjlittle
force-pushed
the
drop-black-and-flake8-conda-requriments
branch
2 times, most recently
from
6f57929
to
e386d89
Compare
trexfeathers
requested changes
Jun 22, 2021
There was a problem hiding this comment.
Thanks @bjlittle, I'm glad you think pre-commit is a good pattern. I have some config suggestions.
Merged
bjlittle
force-pushed
the
drop-black-and-flake8-conda-requriments
branch
from
d21915f
to
dadbc0f
Compare
trexfeathers
approved these changes
Jun 22, 2021
|
@trexfeathers Great, thanks! 🍻 |
Merged
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jul 21, 2021
* main: (43 commits) [pre-commit.ci] pre-commit autoupdate (SciTools#4244) Updated environment lockfiles (SciTools#4242) [pre-commit.ci] pre-commit autoupdate (SciTools#4239) Documented the --force option on conda env create (SciTools#4240) Updated environment lockfiles (SciTools#4237) pre-commit isort and black --check only for cirrus-ci (SciTools#4235) Only run docs-building sessions with Python 3.8. (SciTools#4210) consolidate cirrus-ci documentation tasks (SciTools#4219) Updated environment lockfiles (SciTools#4223) Replace pyke nopyke (SciTools#4198) drop cirrus-ci minimal tests (SciTools#4218) remove change management tech paper (SciTools#4217) [pre-commit.ci] pre-commit autoupdate (SciTools#4213) Updated environment lockfiles (SciTools#4212) Widen cube printout for long ancil or cell-measure names. (SciTools#4124) convert docs print statements (SciTools#4209) optimise pre-commit (SciTools#4208) drop black and flake8 dependencies (SciTools#4181) pre-commit blacked docs (SciTools#4205) pre-commit update (SciTools#4204) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Akin to PR #4174 and
isort, this PR drops theblackandflakepackage dependencies from both ourcondaYAML and PyPIsetup.cfgrequirements.We're now advocating the use of
pre-commitfor developers, which will take care of your linting needs. Additionally, developers (and users alike) can easily install these packages explicitly, if they wish.The reason for dropping these packages is to reduce the
irisdependency bloat, but also due to the regular cadence in version bumping that is required - hardly a major maintenance overhead, but this has cause recent difficulties, particularly withblack.Consult Iris pull request check list