Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow smarter weights (cubes, coordinates, cell measures, or ancillary variables) for aggregation #5084

Merged
merged 25 commits into from
Mar 10, 2023
Merged

Allow smarter weights (cubes, coordinates, cell measures, or ancillary variables) for aggregation #5084

merged 25 commits into from
Mar 10, 2023

Commits on Mar 6, 2023

  1. First implementation for smarter weighted aggregation

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    4656b39 View commit details
    Browse the repository at this point in the history

  2. Allowed arbitrary _DimensionalMetadata for weights

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    fcde563 View commit details
    Browse the repository at this point in the history

  3. Added tests

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    ae4efbb View commit details
    Browse the repository at this point in the history

  4. Added units argument to constructor of Weights

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    c3dd61d View commit details
    Browse the repository at this point in the history

  5. Added documentation

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    401d49d View commit details
    Browse the repository at this point in the history

  6. Fixed tests and added Weights class to API doc

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    546f204 View commit details
    Browse the repository at this point in the history

  7. Fixed tests again

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    c694c4b View commit details
    Browse the repository at this point in the history

  8. Fixed bug which lead to errors when weights was explicitly set to None

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    6dff4a8 View commit details
    Browse the repository at this point in the history

  9. Fixed bug in doc

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    c820183 View commit details
    Browse the repository at this point in the history

  10. Try 1 to fix doctest

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    b4e2e83 View commit details
    Browse the repository at this point in the history

  11. Do not import inherited functions for Weights anymore to avoid doctes… 

    …t failures
    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    43ff2db View commit details
    Browse the repository at this point in the history

  12. Made Weights class private

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    8670788 View commit details
    Browse the repository at this point in the history

  13. Suggestions from code review

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    1b458f9 View commit details
    Browse the repository at this point in the history

  14. Split tests into smaller parts

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    2505fb8 View commit details
    Browse the repository at this point in the history

  15. Re-wrote TestWeights as pytest test

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    768a0c4 View commit details
    Browse the repository at this point in the history

  16. Spellcheck

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    0352241 View commit details
    Browse the repository at this point in the history

  17. Added test for _sum_units_func

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    af9aaab View commit details
    Browse the repository at this point in the history

  18. Ensure backwards-compatibility of Aggregator.units_func

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    69a854f View commit details
    Browse the repository at this point in the history

  19. Restored import order of test

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    0741081 View commit details
    Browse the repository at this point in the history

  20. Added What's new entry

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    fca72f8 View commit details
    Browse the repository at this point in the history

  21. Split further tests

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    8232c9d View commit details
    Browse the repository at this point in the history

  22. Optimized What's new entry

    @schlunma
    schlunma committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    9d8a87a View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Apply suggestions from code review 

    Co-authored-by: lbdreyer <lbdreyer@users.noreply.github.com>
    @schlunma @lbdreyer
    schlunma and lbdreyer authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d1b9c56 View commit details
    Browse the repository at this point in the history

  2. obj cannot be None in _Weights.__array_finalize__

    @schlunma
    schlunma committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    17885c4 View commit details
    Browse the repository at this point in the history

  3. Removed whitespace

    @schlunma
    schlunma committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    ab0a20f View commit details
    Browse the repository at this point in the history