-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite release instructions. #5134
Rewrite release instructions. #5134
Conversation
…s/iris into rewrite_release_instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until it's used with a release it probably won't be put through it's paces enough, but from a cursory overview running through locally, mostly just subjective suggestions.
Will hopefully do a deeper dive during next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @ESadek-MO 🙂
I think it makes sense to try this out in a real release before merging it, since it's so difficult to test. Note that this probably means the What's New entry goes somewhere else eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @trexfeathers. Here's some more comments, having used this in the latest release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for giving this such a thorough test @ESadek-MO. I think I've addressed all your comments.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5134 +/- ##
==========================================
+ Coverage 89.31% 89.32% +0.01%
==========================================
Files 88 89 +1
Lines 22279 22390 +111
Branches 4881 5374 +493
==========================================
+ Hits 19898 20000 +102
- Misses 1635 1640 +5
- Partials 746 750 +4 see 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trexfeathers, looks grand!
I think this will be a dynamic beastie, with edits coming with each release, but I really like where it's at now.
🚀 Pull Request
Description
There are lots of simple steps to a release, making it easy to forget one or do one wrong. This is an ideal application for a do-nothing script, so I've written one.
I've also re-organised the docs page on releases, as that was proving difficult to follow logically. When reviewing it's probably easiest to read it as a new page, rather than trying to track the changes.
To-do:
Consult Iris pull request check list