Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Iris' TestRunner #5205

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Remove Iris' TestRunner #5205

merged 1 commit into from
Mar 23, 2023

Conversation

lbdreyer
Copy link
Member

@lbdreyer lbdreyer commented Mar 22, 2023

Closes #5173

The iris.tests.runner had various functionality. If we remove it we can replace it with the alternative listed below

iris.tests.runner option nox alternative pytest alternative
--default-tests nox --session tests pytest lib/iris/tests
--gallery-tests nox --session gallery pytest docs/gallery_tests
--system-test - pytest lib/iris/tests/system_test.py
--coverage nox --session tests --coverage pytest lib/iris/tests --cov=lib/iris
--create-missing export IRIS_TEST_CREATE_MISSING=True nox --session tests export IRIS_TEST_CREATE_MISSING=True pytest lib/iris/tests
--no-data - -
--num-processors (nox will use auto) pytest -n 2 lib/iris/tests
--stop - pytest -x lib/iris/tests

Before doing this, I didn't even realise the test runner had all these options, e.g. I have always manually set IRIS_TEST_CREATE_MISSING
There is not a direct alternative for every option. For example --no-data doesn't really have an alternative, but I can't really see the use case for this. At a later stage we could consider controlling this with pytest markers.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b228f20) 89.27% compared to head (21fc62a) 89.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5205   +/-   ##
=======================================
  Coverage   89.27%   89.27%           
=======================================
  Files          88       88           
  Lines       22258    22258           
  Branches     4867     4867           
=======================================
  Hits        19871    19871           
  Misses       1641     1641           
  Partials      746      746           
Impacted Files Coverage Δ
lib/iris/config.py 81.17% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@trexfeathers trexfeathers merged commit bf0ce87 into SciTools:main Mar 23, 2023
lbdreyer added a commit to lbdreyer/iris that referenced this pull request Mar 24, 2023
lbdreyer added a commit to lbdreyer/iris that referenced this pull request Mar 24, 2023
lbdreyer added a commit to lbdreyer/iris that referenced this pull request Mar 24, 2023
tkknight added a commit to tkknight/iris that referenced this pull request Apr 4, 2023
* upstream/main: (274 commits)
  Cf cell method (SciTools#5224)
  Bump scitools/workflows from 2023.03.3 to 2023.04.1 (SciTools#5231)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5230)
  Bump scitools/workflows from 2023.03.2 to 2023.03.3 (SciTools#5227)
  raise dask min pin (SciTools#5225)
  Enable lazy computation of wind vector rotation (SciTools#4972)
  Benchmark runner script (SciTools#5215)
  add locks readme (SciTools#5222)
  use explicit version for ci refresh-lockfiles gha (SciTools#5221)
  SciTools#5180 do not run publish-to-test-pypi on forks (SciTools#5220)
  Fix Makefile for consequences of SciTools#5204. (SciTools#5217)
  Bump actions/stale from 7 to 8 (SciTools#5208)
  Remove Iris' TestRunner (SciTools#5205)
  standardize requirements structure (SciTools#5204)
  Updated environment lockfiles (SciTools#5199)
  Add histogram convenience for passing Iris objects to plt.hist (SciTools#5189)
  Updated environment lockfiles (SciTools#5192)
  announce new contributor in whatsnew (SciTools#5198)
  iris.util.new_axis anonymous new dimension fix (SciTools#5194)
  Lockfiles and pydata-sphinx-theme fix (SciTools#5188)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retire Iris' TestRunner
2 participants