-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Iris' TestRunner #5205
Remove Iris' TestRunner #5205
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5205 +/- ##
=======================================
Coverage 89.27% 89.27%
=======================================
Files 88 88
Lines 22258 22258
Branches 4867 4867
=======================================
Hits 19871 19871
Misses 1641 1641
Partials 746 746
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it!
* upstream/main: (274 commits) Cf cell method (SciTools#5224) Bump scitools/workflows from 2023.03.3 to 2023.04.1 (SciTools#5231) [pre-commit.ci] pre-commit autoupdate (SciTools#5230) Bump scitools/workflows from 2023.03.2 to 2023.03.3 (SciTools#5227) raise dask min pin (SciTools#5225) Enable lazy computation of wind vector rotation (SciTools#4972) Benchmark runner script (SciTools#5215) add locks readme (SciTools#5222) use explicit version for ci refresh-lockfiles gha (SciTools#5221) SciTools#5180 do not run publish-to-test-pypi on forks (SciTools#5220) Fix Makefile for consequences of SciTools#5204. (SciTools#5217) Bump actions/stale from 7 to 8 (SciTools#5208) Remove Iris' TestRunner (SciTools#5205) standardize requirements structure (SciTools#5204) Updated environment lockfiles (SciTools#5199) Add histogram convenience for passing Iris objects to plt.hist (SciTools#5189) Updated environment lockfiles (SciTools#5192) announce new contributor in whatsnew (SciTools#5198) iris.util.new_axis anonymous new dimension fix (SciTools#5194) Lockfiles and pydata-sphinx-theme fix (SciTools#5188) ...
Closes #5173
The iris.tests.runner had various functionality. If we remove it we can replace it with the alternative listed below
nox --session tests
pytest lib/iris/tests
nox --session gallery
pytest docs/gallery_tests
pytest lib/iris/tests/system_test.py
nox --session tests --coverage
pytest lib/iris/tests --cov=lib/iris
export IRIS_TEST_CREATE_MISSING=True nox --session tests
export IRIS_TEST_CREATE_MISSING=True pytest lib/iris/tests
auto
)pytest -n 2 lib/iris/tests
pytest -x lib/iris/tests
Before doing this, I didn't even realise the test runner had all these options, e.g. I have always manually set
IRIS_TEST_CREATE_MISSING
There is not a direct alternative for every option. For example --no-data doesn't really have an alternative, but I can't really see the use case for this. At a later stage we could consider controlling this with pytest markers.