Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor refinement to release-do-nothing script #5326

Merged
merged 1 commit into from
May 19, 2023

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented May 19, 2023

🚀 Pull Request

Description

This PR introduces a minor improvement to the release_do_nothing.py script post v3.6.0 release.

We recently enabled automatic deletion of pull request head branches i.e.,

image

This automation is general useful for repo branch hygiene, but will result in the release branch being purged, which isn't necessarily what we want.

The release_do_nothing.py script now includes an additional step to ensure the release branch is restored from the GH GUI with a simple one button click.

As discussed with v3.6.0 release buddy @ESadek-MO off-line 👍


Consult Iris pull request check list

@bjlittle bjlittle requested a review from ESadek-MO May 19, 2023 10:32
@bjlittle bjlittle changed the title minor refinement to release do-nothing script minor refinement to release-do-nothing script May 19, 2023
Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bjlittle!

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8b6eaae) 89.31% compared to head (bc67557) 89.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5326   +/-   ##
=======================================
  Coverage   89.31%   89.31%           
=======================================
  Files          89       89           
  Lines       22375    22375           
  Branches     5368     5368           
=======================================
  Hits        19985    19985           
  Misses       1640     1640           
  Partials      750      750           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ESadek-MO ESadek-MO merged commit 589b1df into SciTools:main May 19, 2023
@bjlittle
Copy link
Member Author

Awesome, nice one @ESadek-MO !

@bjlittle bjlittle deleted the update-do-nothing branch May 19, 2023 11:13
tkknight added a commit to tkknight/iris that referenced this pull request May 21, 2023
* upstream/main:
  Updated environment lockfiles (SciTools#5332)
  Support netcdf variable emulation (SciTools#5212)
  Support netCDF load+save on dataset-like objects as well as filepaths. (SciTools#5214)
  minor refinement to release do-nothing script (SciTools#5326)
  update bibtex citation for v3.6.0 release (SciTools#5324)
  Whats new updates for v3.6.0 (SciTools#5323)
  Added whatsnew notes on netcdf delayed saving and Distributed support. (SciTools#5322)
  Updated environment lockfiles (SciTools#5320)
  Bugfix 4566 (SciTools#4569)
  Simpler/faster data aggregation code in `aggregated_by` (SciTools#4970)
tkknight added a commit to tkknight/iris that referenced this pull request Nov 9, 2023
* upstream/main:
  Updated environment lockfiles (SciTools#5334)
  Iris Docs: Dark theme ready (SciTools#5299)
  Updated environment lockfiles (SciTools#5332)
  Support netcdf variable emulation (SciTools#5212)
  Support netCDF load+save on dataset-like objects as well as filepaths. (SciTools#5214)
  minor refinement to release do-nothing script (SciTools#5326)
  update bibtex citation for v3.6.0 release (SciTools#5324)
  Whats new updates for v3.6.0 (SciTools#5323)
  Added whatsnew notes on netcdf delayed saving and Distributed support. (SciTools#5322)
  Updated environment lockfiles (SciTools#5320)
  Bugfix 4566 (SciTools#4569)
  Simpler/faster data aggregation code in `aggregated_by` (SciTools#4970)
  update release_do_nothing script (SciTools#5311)
  Restore latest Whats New files.
  Updated environment lockfiles (SciTools#5308)
  release_do_nothing script updates from v3.6.0rc0 (SciTools#5306)
  Whats new updates for v3.6.0rc0 (SciTools#5300)
  Bump scitools/workflows from 2023.04.3 to 2023.05.0 (SciTools#5303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants