Fix concatenation of cubes with aux factories #5340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v3.6.x #5340 +/- ##
=======================================
Coverage 89.32% 89.32%
=======================================
Files 89 89
Lines 22393 22398 +5
Branches 5375 5375
=======================================
+ Hits 20003 20008 +5
Misses 1640 1640
Partials 750 750
☔ View full report in Codecov by Sentry. |
schlunma
force-pushed
the
fix_aux_factory_concat
branch
from
3bedcd5
to
28f4792
Compare
trexfeathers
requested changes
Jun 15, 2023
There was a problem hiding this comment.
Thanks @schlunma, I ran the script in #5339 and I can confirm that this fixes the error.
Two things:
- The comment below about checking dimension spanning
- Once Fix #5347 #5349 has been merged (which will include the special patch What's New section): please could you include a What's New entry
schlunma
force-pushed
the
fix_aux_factory_concat
branch
from
28f4792
to
04a1e18
Compare
schlunma
force-pushed
the
fix_aux_factory_concat
branch
from
04a1e18
to
6da8979
Compare
trexfeathers
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR makes sure to properly update all aux factory dependencies when concatenating cubes.
Closes #5339
Consult Iris pull request check list