Document use of new_axis to control merge #6180
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6180 +/- ##
========================================
Coverage 89.81% 89.82%
========================================
Files 88 88
Lines 23174 23185 +11
Branches 5045 4314 -731
========================================
+ Hits 20814 20825 +11
- Misses 1623 1628 +5
+ Partials 737 732 -5 ☔ View full report in Codecov by Sentry. |
pp-mo
requested changes
Oct 21, 2024
| 13: x_wind / (m s-1) (model_level_number: 5; time: 1; latitude: 144; longitude: 192) | ||
| 14: x_wind / (m s-1) (model_level_number: 5; time: 1; latitude: 144; longitude: 192) | ||
|
|
||
| Once merged, we can now concatenate these cubes together: |
There was a problem hiding this comment.
Suggested change
| Once merged, we can now concatenate these cubes together: | |
| Once merged, we can now concatenate all these cubes into a single result cube, which is what we wanted: |
pp-mo
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Sorry, nearly there but there are a few problems remaining.
- a couple of further suggestions on the diff
- you need to include the new page in the 'further topics' TOC, since that doesn't happen automatically, and I couldn't view the built page in the docs even by substituting the page name
I think you just need to add it here - the docs build is now working, but the doctests are still failing. I think it's a cartopy compatibility problem, which I hope may be fixed by just updating the branch, but I'll leave you to do that in case something goes wrong
| 74: x_wind / (m s-1) (time: 1; latitude: 144; longitude: 192) | ||
|
|
||
| Then we merge, promoting the different ``model_level_number`` scalar coordinates to a dimension coordinate. | ||
| Note, however, that merging these cubes does _not_ affect the ``time`` dimension, since merging only |
There was a problem hiding this comment.
Suggested change
| Note, however, that merging these cubes does _not_ affect the ``time`` dimension, since merging only | |
| Note, however, that merging these cubes does *not* affect the ``time`` dimension, since merging only |
Sorry, my mistake, underscores are for markdown not RST !
| .. _controlling_merge: | ||
|
|
||
| ================= | ||
| Controlling Merge |
There was a problem hiding this comment.
Is it anyway better to call this "Controlling Merge and Concatenate" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Closes #6162.
Requires SciTools/iris-sample-data#33.
May need to be adapted to account for #6168.