Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the -k explicit option when creating lockfiles in CI #107

Merged
merged 2 commits into from
Apr 2, 2022

Conversation

spencerkclark
Copy link
Member

@spencerkclark spencerkclark commented Apr 2, 2022

🚀 Pull Request

Description

From @rcomer: the latest version of conda-lock creates lockfiles by default that cannot be used to generate environments with conda/mamba. Using the -k explicit option restores the old behavior.

See also: SciTools/iris#4644.

@rcomer
Copy link
Member

rcomer commented Apr 2, 2022

@spencerkclark in Iris we fixed this by using the “explicit” option which produces old-style lockfiles that still work to generate an environment with conda/mamba. With the new-style lockfiles, the environment has to be generated with conda-lock.
SciTools/iris#4644

@codecov-commenter
Copy link

Codecov Report

Merging #107 (ae0532a) into main (aec8a37) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files           1        1           
  Lines         194      194           
  Branches       50       50           
=======================================
  Hits          183      183           
  Misses          6        6           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec8a37...ae0532a. Read the comment docs.

@spencerkclark
Copy link
Member Author

Ah thank you @rcomer! My first try was a bit of a shot in the dark...it did occur to me afterwards that you must have solved it elsewhere already. I appreciate you pointing me to the simple fix.

@spencerkclark spencerkclark changed the title Specify name of lockfile in .cirrus.yml Use the -k explicit option when creating lockfiles in CI Apr 2, 2022
@rcomer rcomer merged commit 0b3a227 into SciTools:main Apr 2, 2022
@spencerkclark spencerkclark deleted the fix-ci branch April 2, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants