Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min pin for cftime #69

Merged
merged 1 commit into from
Jun 14, 2021
Merged

min pin for cftime #69

merged 1 commit into from
Jun 14, 2021

Conversation

bjlittle
Copy link
Member

🚀 Pull Request

Description

This PR introduced a minimum pin of cftime>=1.5, otherwise it is possible for nc-time-axis 1.13.0 to be resolved with an incompatible version of cftime within a conda/pip environment

@bjlittle bjlittle added New: Pull Request Highlight a new community raised pull-request Type: Infrastructure labels Jun 14, 2021
@bjlittle bjlittle requested a review from trexfeathers June 14, 2021 11:44
@codecov-commenter
Copy link

Codecov Report

Merging #69 (300b867) into v1.3.x (b459313) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           v1.3.x      #69   +/-   ##
=======================================
  Coverage   89.08%   89.08%           
=======================================
  Files           1        1           
  Lines         174      174           
  Branches       42       42           
=======================================
  Hits          155      155           
  Misses         13       13           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b459313...300b867. Read the comment docs.

@trexfeathers trexfeathers merged commit eb2ff09 into SciTools:v1.3.x Jun 14, 2021
@bjlittle
Copy link
Member Author

@trexfeathers Awesome, thanks!

spencerkclark pushed a commit to spencerkclark/nc-time-axis that referenced this pull request Aug 14, 2021
@bjlittle bjlittle deleted the release-patch branch April 26, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New: Pull Request Highlight a new community raised pull-request Type: Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants