Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NetCDFTimeConverter.convert with list #78

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Fix NetCDFTimeConverter.convert with list #78

merged 3 commits into from
Aug 9, 2021

Conversation

aulemahal
Copy link
Contributor

🚀 Pull Request

Description

Fixes #47 and fixes #74. Now NetCDFTimeConverter.convert accepts lists or tuples, as given by matplotlib when using fill_between and axhspan (and maybe others).

Added a unit test and an integration one.

@aulemahal aulemahal requested a review from spencerkclark August 9, 2021 20:07
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #78 (24f69f8) into main (bf50478) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   89.08%   89.20%   +0.12%     
==========================================
  Files           1        1              
  Lines         174      176       +2     
  Branches       42       43       +1     
==========================================
+ Hits          155      157       +2     
  Misses         13       13              
  Partials        6        6              
Impacted Files Coverage Δ
nc_time_axis/__init__.py 89.20% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf50478...24f69f8. Read the comment docs.

Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @aulemahal. Just one minor nit, and perhaps could you also add a test similar to test_cftime_list_date that tests if a tuple of dates is passed to convert?

nc_time_axis/__init__.py Show resolved Hide resolved
nc_time_axis/__init__.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nc-time-axis dates don't work with plt.fill_between(...) Not converting values when passed a list
3 participants