M dwarfs tess #33
M dwarfs tess #33
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,1285 @@ | |||
| { | |||
There was a problem hiding this comment.
This is a great intro. Make sure to add some links to background information about M Dwarfs. Also it would be cool to link to a paper on the habitability of planets around M Dwarfs, my quick google search yielded this paper: https://doi.org/10.48550/arXiv.2203.10127
Reply via ReviewNB
| @@ -0,0 +1,1285 @@ | |||
| { | |||
There was a problem hiding this comment.
You should briefly describe what's in the other notebook (~1-2 sentences), then put a [link here]. I'll make sure that when the notebooks go live, an appropriate link is added
Reply via ReviewNB
| @@ -0,0 +1,1285 @@ | |||
| { | |||
There was a problem hiding this comment.
Having read through this section, I think you should motivate iterating through the "removing variability" steps. Why are we cleaning twice?
Reply via ReviewNB
| @@ -0,0 +1,1285 @@ | |||
| { | |||
There was a problem hiding this comment.
This cleaned data looks.... ok. The first lightcurve in the list actually looks a little better to my eye; is there a reason you went with this one?
Reply via ReviewNB
There was a problem hiding this comment.
@ttdu this lightcurve was one of the lightcurves with more easily parseable periodograms. I could mention this in the intro, if that's helpful!
| @@ -0,0 +1,1285 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #2. sigma_2 = convolve(np.square(cleaned_twice - running_mean), g)
This 'g' factor does not appear in the notebook, so this cell failed when I ran it.
Reply via ReviewNB
| @@ -0,0 +1,1285 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1285 @@ | |||
| { | |||
There was a problem hiding this comment.
It looks like some extra-long flares are getting marked twice. Should we perhaps raise our standards to 8 or 10 minutes? Or would this exclude too many flares?
Reply via ReviewNB
| @@ -0,0 +1,1285 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1328 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1328 @@ | |||
| { | |||
There was a problem hiding this comment.
|
@arjunsavel , Please give another round of polish taking into account Tom and my comments. |
Short notebook for finding flares in TESS — related to the HST M dwarf notebook, loosely.