Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schedule trigger to build a nightly release a 22h30 every day #6626

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

FirelightFlagboy
Copy link
Contributor

I needed to update the dependent workflows to use the commit SHA from the newly created nightly commit. The schedule job was put in releaser workflow because Github Actions aren't trigger by actions originating from itself.

If I have a workflow the respond to push to master,
and I have another workflow that push a commit to master authenticated using GH_TOKEN.
the first one will not be triggered by the action of second one.

@FirelightFlagboy FirelightFlagboy requested a review from a team as a code owner March 7, 2024 09:28
@FirelightFlagboy FirelightFlagboy force-pushed the schedule-nightly-build branch 3 times, most recently from 7be2308 to 81873c2 Compare March 7, 2024 09:53
@FirelightFlagboy
Copy link
Contributor Author

Currently the setup would not work as we need to authorized github-action[bot] permission for the branch releases/nightly & tag nightly

Copy link
Contributor

@mmmarcos mmmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/_releaser_nightly_build.yml Outdated Show resolved Hide resolved
I needed to update the dependent workflows to use the commit SHA from the newly created nightly commit.
The schedule job was put in `releaser` workflow because Github Actions aren't trigger by actions originating from itself.

> If I have a workflow the respond to push to `master`,
> and I have another workflow that push a commit to `master` authenticated using `GH_TOKEN`.
> the first one will not be triggered by the action of second one.

Other Changes
-------------

- `releaser.py`:
  - Add option to not sign the commit or tag.
  - Verify the gpg signature only if `gpg_sign is True`
- `releaser.yml`: Run jobs dependent of `version` on `success`.

Co-authored-by: Marcos Medrano <786907+mmmarcos@users.noreply.github.com>
@FirelightFlagboy FirelightFlagboy requested a review from a team as a code owner March 11, 2024 13:28
@FirelightFlagboy FirelightFlagboy added this pull request to the merge queue Mar 11, 2024
Merged via the queue into master with commit c930f8b Mar 11, 2024
36 checks passed
@FirelightFlagboy FirelightFlagboy deleted the schedule-nightly-build branch March 11, 2024 14:27
@FirelightFlagboy FirelightFlagboy mentioned this pull request Mar 12, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants