Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ida-free@8.1: Fix (un)install scripts #9603

Merged
merged 1 commit into from
Oct 29, 2022
Merged

ida-free@8.1: Fix (un)install scripts #9603

merged 1 commit into from
Oct 29, 2022

Conversation

HUMORCE
Copy link
Member

@HUMORCE HUMORCE commented Oct 29, 2022

Closes #9421 #9436

related: ScoopInstaller/Scoop#5065

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

ida-free

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@HUMORCE
Copy link
Member Author

HUMORCE commented Oct 29, 2022

the manifest is currently working, but I think it is affected by bug, reported here: ScoopInstaller/Scoop#5231

@HUMORCE HUMORCE merged commit 29b27cd into master Oct 29, 2022
@HUMORCE HUMORCE deleted the fix-ida-free branch October 29, 2022 07:09
@FlawlessCasual17
Copy link
Contributor

@HUMORCE there was a reason I changed, the installer.script property. The "args" variable of the property does not work properly, which is why I used "script" instead.

@HUMORCE
Copy link
Member Author

HUMORCE commented Oct 29, 2022

I made this PR because you used sleep in script, which also caused the installation fail.

@FlawlessCasual17
Copy link
Contributor

Oh, so that's why, carry on with your day then, my bad.

TonyApuzzo pushed a commit to TonyApuzzo/Extras that referenced this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ida-free 8.1 install failed
2 participants