Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wixtoolset: Update to version 5.0.0 #5552

Merged
merged 4 commits into from
Apr 9, 2024
Merged

wixtoolset: Update to version 5.0.0 #5552

merged 4 commits into from
Apr 9, 2024

Conversation

chawyehsu
Copy link
Member

@chawyehsu chawyehsu commented Feb 27, 2024

Don't know if it is proper to update to v4 directly but Wix 4 works totally different from its previous versions... This will be a breaking change I think. Wix 4 is required to unpack installers that are packed with Wix 4, which means dark, removed in Wix 4, will not work anymore for this kind of installers, taking swift as the example..

P.S. Wix 5 release is planning..

Closes #XXXX

Relates to #5466, #5521

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

wixtoolset

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@chawyehsu
Copy link
Member Author

! DON'T merge until consensus is made.

@niheaven
Copy link
Member

niheaven commented Feb 29, 2024

This is why I made ScoopInstaller/Versions#1606 and this could be updated to v4. But this may break some codes in Scoop Core (https://github.com/ScoopInstaller/Scoop/blob/f93028001fbe5c78cc41f59e3814d2ac8e595724/lib/core.ps1#L318-L323 and https://github.com/ScoopInstaller/Scoop/blob/f93028001fbe5c78cc41f59e3814d2ac8e595724/libexec/scoop-checkup.ps1#L32-L34).

Nevertheless, update wix to 4 and I'll update core soon (most users are install dark directly IMO).

Ed. I made a commit instead of a review by mistake. Please review the last commit which was used by me locally @chawyehsu

@niheaven
Copy link
Member

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

wixtoolset

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@niheaven niheaven changed the title wixtoolset: Update to v4 wixtoolset: Update to version 5.0.0 Apr 8, 2024
@niheaven
Copy link
Member

niheaven commented Apr 8, 2024

/verify

Copy link
Contributor

github-actions bot commented Apr 8, 2024

All changes look good.

Wait for review from human collaborators.

wixtoolset

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@niheaven
Copy link
Member

niheaven commented Apr 8, 2024

This could be merged 'cos wix burn extract does the same thing as dark, see ScoopInstaller/Scoop#5871

@chawyehsu chawyehsu merged commit be99756 into master Apr 9, 2024
4 checks passed
@chawyehsu chawyehsu deleted the wix4 branch April 9, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants