fix(decompress): Handle split RAR archives #4994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashil2000
reviewed
Jun 19, 2022
Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
rashil2000
previously approved these changes
Jun 23, 2022
niheaven
previously approved these changes
Jun 24, 2022
niheaven
changed the title
slaughtering
pushed a commit
to slaughtering/scoop
that referenced
this pull request
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of fix(depends): Avoid digits in archive file extension #4915.
Splitted RAR archives is rare for normal apps, but it is still possible for games or something with a large file size.
File name for splitted RAR archives can be: something.part1.rar, something.part01.rar, something.part001.rar, ..., depending on total number of splits.
For
TestCases.zip: I tried to compressemptyinto 3 RAR archives (30 Bytes each), but it didn't work. WinRAR rather creates a single file. The minimum size for RAR split archive is 925 Bytes according to my tests. (not sure why though)