Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chore): Add missing -a/--all param to all commands #5004

Merged
merged 7 commits into from
Jun 22, 2022
Merged

Conversation

rashil2000
Copy link
Member

@rashil2000 rashil2000 commented Jun 21, 2022

Closes #5027

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven
Copy link
Member

LGTM for 'cache' and 'reset', but for 'virustotal', the -e sounds strange, and why not remove arch and let -a stands for --all?

Users check not-installed app's URLs for both 32bit and 64bit, right?

@rashil2000
Copy link
Member Author

Users check not-installed app's URLs for both 32bit and 64bit, right?

I'm not really sure about this.

For consistency I can remove the arch flag, and use the system's default architecture only. What should we do?

@niheaven
Copy link
Member

For consistency I can remove the arch flag, and use the system's default architecture only. What should we do?

I prefer to check both for not installed apps, and only check used architecture if installed.

niheaven
niheaven previously approved these changes Jun 22, 2022
Copy link
Member

@niheaven niheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rashil2000 rashil2000 merged commit 9811a5f into develop Jun 22, 2022
@rashil2000 rashil2000 deleted the reset-all branch June 22, 2022 10:17
slaughtering pushed a commit to slaughtering/scoop that referenced this pull request Jul 7, 2022
…er#5004)

* feat(scoop-reset): Add -a/--all switch to reset all apps

* feat(scoop-cache): Add -a/--all switch to delete whole cache

* feat(scoop-virustotal): Add -e/--every switch to check every installed app

* Update CHANGELOG.md

* use 'all' instead of 'every'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants