Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Change config option to snake_case in file and SCREAMING_CASE in code #5116

Merged
merged 5 commits into from
Aug 21, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Aug 20, 2022

Description

Use snake_case in ~/.config/scoop.json and CREAMING_CASE in Scoop code for config options.

Also change some config options' name:

  • lastupdate -> last_update
  • 7ZIPEXTRACT_USE_EXTERNAL -> use_external_7zip
  • MSIEXTRACT_USE_LESSMSI -> use_lessmsi
  • NO_JUNCTIONS -> no_junction
  • manifest_review -> show_manifest
  • rootPath -> root_path
  • globalPath -> global_path
  • cachePath -> cache_path

Motivation and Context

How Has This Been Tested?

NOTICE If someone want to test this PR, please backup ~/.config/scoop.json 😄

Local tests (.\bin\test.ps1) passed, and scoop config gives a warning if use old names. (BTW, PowerShell is case insensitive)

image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven requested a review from r15ch13 August 20, 2022 10:54
r15ch13
r15ch13 previously approved these changes Aug 20, 2022
Signed-off-by: Hsiao-nan Cheung <niheaven@gmail.com>
r15ch13
r15ch13 previously approved these changes Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants