feat(config): Allow scoop to check and update 'nightly' apps #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashil2000
previously approved these changes
Oct 6, 2022
|
Got the idea, but the implement and test need to be tweaked, will review and fix after 0.3.0 release. |
|
Please check the code, and this should be done after 0.3.0. |
rashil2000
reviewed
Oct 11, 2022
Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
niheaven
approved these changes
Oct 14, 2022
niheaven
changed the title
github-actions bot
pushed a commit
to pukkandan/Scoop
that referenced
this pull request
Oct 20, 2022
…staller#5166) Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new config option
check_nightly_outdated.When set to true, while checking if an app version is old (e.g. for
scoop update *), Scoop will check the date on apps whose installed versions are formatted as 'nightly-yyyyMMdd'. For apps versioned as 'nightly', the date is already appended to the installed version by Scoop upon install. Alternatively, the date could already be included in the manifest (e.g. goneovim-nightly).If the date is found to be a day old or more, Scoop considers the version outdated.
Date format ref: https://learn.microsoft.com/en-us/dotnet/standard/base-types/custom-date-and-time-format-strings
Motivation and Context
Closes #4077
How Has This Been Tested?
A few tests have been added to Scoop-Versions.Tests.ps1
On my machine:
scoopis my current, normal install of scoop, followingmasterbin\scoop.ps1features the proposed featureChecklist:
developbranch.Not sure if my documentation added to scoop-config.ps1 is clear and simple enough to the end user. I'm considering removing the technical part about the date format and how Scoop checks the version number.