Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(bucket): Use BuildHelpers EnvVars #5226

Merged
merged 2 commits into from
Oct 28, 2022
Merged

tests(bucket): Use BuildHelpers EnvVars #5226

merged 2 commits into from
Oct 28, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Oct 28, 2022 •
edited
Loading

Description

Using $env:BH* to simplify code.

Motivation and Context

How Has This Been Tested?

See niheaven/scoop-nih#7

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven changed the title refactor(hash): Use 'Get-FileHash()' directly (#5177) tests(bucket): Use BuildHelpers Oct 28, 2022
@niheaven niheaven changed the title tests(bucket): Use BuildHelpers tests(bucket): Use BuildHelpers EnvVars Oct 28, 2022
@niheaven niheaven merged commit ea6c738 into develop Oct 28, 2022
@niheaven niheaven deleted the fix-bucket-tests branch October 28, 2022 07:20
@niheaven niheaven mentioned this pull request Oct 28, 2022
Merged
1 task
@niheaven niheaven mentioned this pull request Nov 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@niheaven