Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scoop-info) --verbose file size collection #5352

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

starthal
Copy link
Contributor

@starthal starthal commented Jan 20, 2023

Description

Make the file size collection not error on normal use

  • Join app path to the base path
  • Do not attempt to measure Length of directories in the tree

Motivation and Context

scoop info [app] --verbose was failing in two locations.

How Has This Been Tested?

Only tested locally with scoop info dos2unix --verbose and scoop info llvm --verbose

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

libexec/scoop-info.ps1 Outdated Show resolved Hide resolved
libexec/scoop-info.ps1 Outdated Show resolved Hide resolved
- Use full path for files
- Do not attempt to measure `Length` of directories in the tree

Co-authored-by: Richard Kuhnt <r15ch13+git@gmail.com>
@r15ch13 r15ch13 merged commit 8acfeee into ScoopInstaller:develop Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants