Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builds(checkver): Read the private_host config variable #5381

Conversation

Ercolino
Copy link
Contributor

@Ercolino Ercolino commented Feb 9, 2023

Description

Checkver does not read the private_hosts config variable. That's mean it is not possible to add a url endpoint which points for example to a text file in a private repository, wherein you can query the current version of your app.

Relates to #5380

How Has This Been Tested?

Just run the CI Tests.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@Ercolino Ercolino changed the base branch from master to develop February 9, 2023 21:22
CHANGELOG.md Outdated Show resolved Hide resolved
@niheaven niheaven changed the title fix(core): Checkver cannot read private_hosts config variable builds(checkver): Read the private_host config variable Feb 18, 2023
niheaven
niheaven previously approved these changes Feb 18, 2023
@niheaven niheaven merged commit 1d0bd43 into ScoopInstaller:develop Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants